fix: implemented exception handling for client indefinite blocks #500
+115
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- propagated the error once value error is raised instead of send it to stream - added exception groups to handle value error as well as connection error etc with exception groups - added errors list to add the exception groups and convert it to normal exception and throw to client
Seems like |
* added exceptiongroup dependency in toml for handling exception group issue from python 3.10 to python 3.13 * added handle_exception function to handle the exceptions * updated the uv.lock
- changed the handle_exception functions implementation - replaced the Exception parameter with BaseExceptionGroup[Exception]
|
@jerome3o-anthropic @jspahrsummers @dsp-ant Adding here for PR review |
…er-has-incorrect-base-url
|
@Kludex Synced the PR. It’s up to date with main |
…er-has-incorrect-base-url
|
@Kludex @jerome3o-anthropic Synced the PR. It's up to date with main |
…er-has-incorrect-base-url
|
@Kludex Synced the PR. |
…er-has-incorrect-base-url
|
@dsp-ant @jerome3o-anthropic @Kludex Synced the PR with main |
…er-has-incorrect-base-url
|
@dsp-ant @jerome3o-anthropic @Kludex @ihrpr Synced the PR with main. Guys I've been following this PR and syncing for past 3 weeks I'm not getting any feedback and suggestions on this. I'd be happy to know the status of this PR |
…er-has-incorrect-base-url
|
@dsp-ant @jerome3o-anthropic @Kludex @ihrpr Synced the PR with main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #447
Mismatch URL
Connection Error
Motivation and Context
This PR solves the indefinite blocking issue of the client by handling the exception thrown by url mismatch and also all the exceptions happens during connection:
How Has This Been Tested?
uv pip install /dist/mcp-1.6.1.dev12+70115b9-py3-none-any.whlin the local servers.Breaking Changes
There are no breaking changes.
Types of changes
Checklist